Support building a package from dev_container #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @cliffburdick |
|
Hi @agirault, some |
|
@mocsharp If you have a specific test to run, can you provide instructions? ty |
agirault
force-pushed
the
ag/package-from-dev-container
branch
from
f4c13d2 to
dbb6a7b
Compare
Need capabilities to retrieve dockerfile needed for building the package subcomponents Signed-off-by: Alexis Girault <[email protected]>
Signed-off-by: Alexis Girault <[email protected]>
agirault
force-pushed
the
ag/package-from-dev-container
branch
from
d37ed11 to
a765ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
build_and_packageto./dev_containerthat leveragesbuild_and_runsimilarly tobuild_and_install. Bit of a workaround, butbuild_and_runmight be refactored in the somewhat near future.Results
./dev_container build_and_package holoscan-networking Building dev container... 2025-02-20 21:24:59 $ /home/agirault/projects/holoscan/holohub/dev_container build --docker_file operators/advanced_network/Dockerfile --img holohub:holoscan-networking 2025-02-20 21:24:59 $ export DOCKER_BUILDKIT=1 2025-02-20 21:24:59 $ docker build --build-arg BUILDKIT_INLINE_CACHE=1 --build-arg BASE_IMAGE=nvcr.io/nvidia/clara-holoscan/holoscan:v2.9.0-dgpu --build-arg GPU_TYPE=dgpu --build-arg COMPUTE_CAPACITY=8.6 --network=host -f operators/advanced_network/Dockerfile -t holohub:holoscan-networking /home/agirault/projects/holoscan/holohub ... [command] cpack --config build/holoscan-networking/pkg/CPackConfig-holoscan-networking.cmake CPack: Create package using DEB CPack: Install projects CPack: - Run preinstall target for: Holohub CPack: - Install project: Holohub [] CPack: Create package CPack: - package: /workspace/holohub/holoscan-networking_0.1.0_arm64.deb generated. Build done../dev_container build_and_package foo Package foo not found in list of packages: (see ./run list_packages)